Skip to content

refactor(ra-tls): separate attestation from issuer claims - #967

Open
kvinwang wants to merge 2 commits into
masterfrom
codex/fix-ra-tls-app-extensions
Open

refactor(ra-tls): separate attestation from issuer claims#967
kvinwang wants to merge 2 commits into
masterfrom
codex/fix-ra-tls-app-extensions

Conversation

@kvinwang

@kvinwang kvinwang commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Problem

VerifiedRaTlsCert mixed two different trust domains in one result type:

  • attestation evidence verified against a TEE trust root and bound to the certificate public key
  • app-id, app-info, and usage extensions whose authenticity comes from normal certificate-chain validation and the KMS issuer

Putting both in a type named VerifiedRaTlsCert made issuer claims look attestation-verified. It also encouraged comparing them to embedded attestation even though KMS-issued certificates may intentionally omit attestation.

Change

  • rename the result to VerifiedRaTlsAttestation
  • return only the certificate public key and verified attestation evidence
  • provide decode_app_info() to derive application identity from verified evidence when attestation is present
  • stop returning issuer-backed certificate extensions from the attestation verification API
  • make verifier certificate output report application identity only from verified attestation
  • document that KMS certificate claims must be consumed after normal certificate-chain verification

This preserves the intended trust model: KMS signs and backs certificate identity extensions, while RA-TLS attestation verification is a separate optional proof bound to the leaf key.

Verification

  • cargo fmt --manifest-path dstack/Cargo.toml --all
  • cargo test --manifest-path dstack/Cargo.toml -p ra-tls
  • cargo check --manifest-path dstack/Cargo.toml -p dstack-verifier
  • cargo clippy --manifest-path dstack/Cargo.toml -p ra-tls -p dstack-verifier --all-targets -- -D warnings
  • git diff --check

Copilot AI review requested due to automatic review settings July 31, 2026 03:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kvinwang
kvinwang force-pushed the codex/fix-ra-tls-app-extensions branch from 16e8603 to 4ee4de0 Compare August 5, 2026 11:55
Base automatically changed from codex/fix-ra-tls-security-profile to master August 5, 2026 12:32
@kvinwang
kvinwang force-pushed the codex/fix-ra-tls-app-extensions branch from 4ee4de0 to 0eee38d Compare August 5, 2026 12:32
@kvinwang
kvinwang force-pushed the codex/fix-ra-tls-app-extensions branch from 0eee38d to 7d6f449 Compare August 5, 2026 16:24
@kvinwang kvinwang changed the title [STACKED on #938] fix(ra-tls): bind certificate app extensions refactor(ra-tls): separate attestation from issuer claims Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants