refactor(ra-tls): separate attestation from issuer claims - #967
Open
kvinwang wants to merge 2 commits into
Open
Conversation
kvinwang
force-pushed
the
codex/fix-ra-tls-app-extensions
branch
from
August 5, 2026 11:55
16e8603 to
4ee4de0
Compare
kvinwang
force-pushed
the
codex/fix-ra-tls-app-extensions
branch
from
August 5, 2026 12:32
4ee4de0 to
0eee38d
Compare
kvinwang
force-pushed
the
codex/fix-ra-tls-app-extensions
branch
from
August 5, 2026 16:24
0eee38d to
7d6f449
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
VerifiedRaTlsCertmixed two different trust domains in one result type:app-id,app-info, and usage extensions whose authenticity comes from normal certificate-chain validation and the KMS issuerPutting both in a type named
VerifiedRaTlsCertmade issuer claims look attestation-verified. It also encouraged comparing them to embedded attestation even though KMS-issued certificates may intentionally omit attestation.Change
VerifiedRaTlsAttestationdecode_app_info()to derive application identity from verified evidence when attestation is presentThis preserves the intended trust model: KMS signs and backs certificate identity extensions, while RA-TLS attestation verification is a separate optional proof bound to the leaf key.
Verification
cargo fmt --manifest-path dstack/Cargo.toml --allcargo test --manifest-path dstack/Cargo.toml -p ra-tlscargo check --manifest-path dstack/Cargo.toml -p dstack-verifiercargo clippy --manifest-path dstack/Cargo.toml -p ra-tls -p dstack-verifier --all-targets -- -D warningsgit diff --check